Add mention of CORERUN_IN_BROWSER variable#126143
Conversation
I was scratching my head over how this should work, this was the missing piece. I also moved the paragraph about copying files since it needs to happen before dotnet-serve.
There was a problem hiding this comment.
Pull request overview
Updates the CoreCLR WebAssembly build/run documentation to cover the missing CORERUN_IN_BROWSER toggle and to reorder steps so required file copying happens before serving the output directory.
Changes:
- Document enabling the browser workflow by setting
CORERUN_IN_BROWSERincorerun’s CMake configuration. - Move the “populate
WASM_PRELOAD_DIR/ copy IL assets” guidance earlier so it occurs beforedotnet-serve. - Clarify that
corerun.htmlis the browser entry point and may be missing if the browser workflow wasn’t enabled.
🤖 Copilot Code Review — PR #126143Note This review was generated by GitHub Copilot. Holistic AssessmentMotivation: Justified. The Approach: Sound. The change front-loads the Summary: ✅ LGTM. This is a small, focused documentation improvement. The factual claims are accurate (verified Detailed Findings✅ Accuracy — Variable references verifiedBoth ✅ Structure — Improved logical flowMoving prerequisites ( ✅ Formatting — Clean markdownNo trailing whitespace, proper blank-line separation between paragraphs, backtick formatting for variable names and file paths is consistent with the rest of the document.
|
The puzzle was missing a piece.
I also moved the paragraph about copying files since it needs to happen before dotnet-serve.
Cc @pavelsavara @radekdoulik