EmccCompile: prefer TryRunProcess over RunShellCommand.#126150
EmccCompile: prefer TryRunProcess over RunShellCommand.#126150tmds wants to merge 4 commits intodotnet:mainfrom
Conversation
A shell is not needed to run emcc.
|
Thank you @tmds for the contribution! There are test failures related to the change https://github.com/dotnet/runtime/pull/126150/checks?check_run_id=68749851592 |
maraf
left a comment
There was a problem hiding this comment.
I'm thinking if there wasn't reason to put the command in batch file, something like too long input
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
|
There is problem with too long list of arguments. |
It seems that on Windows emcc is invokable as
I think this is independent of the changes made here. |
A shell is not needed to run emcc.