Disable FastReducer_AssertFailure_RegressionTest on 32-bit platforms#126216
Disable FastReducer_AssertFailure_RegressionTest on 32-bit platforms#126216stephentoub merged 2 commits intomainfrom
Conversation
#126212) Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f49be4b4-cc0d-4da8-bdf2-d34e4aba7a24 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Disables a flaky/hanging BigInteger modular exponentiation regression test on 32-bit processes while an upstream issue is investigated (#126212). This keeps CI reliable on 32-bit platforms without removing the test coverage elsewhere.
Changes:
- Added an
[ActiveIssue]attribute to skipFastReducer_AssertFailure_RegressionTestwhenPlatformDetection.Is32BitProcessis true.
🤖 Copilot Code Review — PR #126216Note This review was generated by GitHub Copilot. Holistic AssessmentMotivation: The PR addresses a real, observed CI failure — Approach: Using Summary: ✅ LGTM. This is a minimal, well-targeted workaround that follows established codebase conventions. The change is a single attribute addition, correctly uses the Detailed Findings✅ Correctness — Attribute usage is correctThe ✅ Scope — Change is appropriately narrowThe PR touches exactly one line in one file. No unrelated changes, no whitespace noise. The test data provider ( ✅ Test coverage — 64-bit platforms unaffectedThe ✅ Tracking — Issue is properly documentedIssue #126212 includes the CI build links showing the timeout, the callstack identifying the hang location (
|
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you for unblocking the CI runs!
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g a lot of Unable to pull image... infra failures unrelated to the change |
Workaround for a failure in
FastReducer_AssertFailure_RegressionTeston 32-bit platforms tracked in #126212.Description
Adds
[ActiveIssue]to skipFastReducer_AssertFailure_RegressionTestwhen running as a 32-bit process:AI-Generated Content
Note
This PR description and the associated code changes were generated by GitHub Copilot.