Add dependencies for type map group type for external/proxy type map nodes#126383
Merged
jkoritzinsky merged 2 commits intodotnet:mainfrom Apr 1, 2026
Merged
Add dependencies for type map group type for external/proxy type map nodes#126383jkoritzinsky merged 2 commits intodotnet:mainfrom
jkoritzinsky merged 2 commits intodotnet:mainfrom
Conversation
jkoritzinsky
force-pushed
the
typemap-fix
branch
from
b2dc6f0 to
4977f77
Compare
jkoritzinsky
requested review from
AaronRobinsonMSFT,
davidwrighton,
lewing,
mangod9 and
pavelsavara
and removed request for
AaronRobinsonMSFT,
lewing and
pavelsavara
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses ReadyToRun (R2R) compilation failures by ensuring the type-map group type is included as an import dependency for external and proxy type map nodes, so the emitted type map can correctly reference the group type.
Changes:
- Add an explicit
ImportReferenceProvider.GetImportToType(TypeMapGroup)dependency toReadyToRunProxyTypeMapNode. - Add an explicit
ImportReferenceProvider.GetImportToType(TypeMapGroup)dependency toReadyToRunExternalTypeMapNode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunProxyTypeMapNode.cs | Adds a dependency import for the type map group type used when emitting proxy type maps. |
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunExternalTypeMapNode.cs | Adds a dependency import for the type map group type used when emitting external type maps. |
src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunProxyTypeMapNode.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunExternalTypeMapNode.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 1, 2026
Open
mangod9
approved these changes
Apr 1, 2026
Member
Author
|
/ba-g unrelated timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failures seen in https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-125352-merge-8b18d53375fc46aebf/Interop/1/console.97161f8d.log?helixlogtype=result&skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2026-03-31T22%3A49%3A53Z&ske=2026-03-31T23%3A49%3A53Z&sks=b&skv=2026-02-06&sv=2026-02-06&se=2026-03-31T23%3A49%3A53Z&sr=b&sp=rl&sig=dMNTuiOlpfDd5Ah0u4sB%2BzF0PpYpCycZ1MRPERCCSzc%3D