arm64: Refactor mov/movprfx for embedded masked operations#126398
Open
ylpoonlg wants to merge 1 commit intodotnet:mainfrom
Open
arm64: Refactor mov/movprfx for embedded masked operations#126398ylpoonlg wants to merge 1 commit intodotnet:mainfrom
ylpoonlg wants to merge 1 commit intodotnet:mainfrom
Conversation
* Add an option for SVE mov/movprfx to differentiate between unpredicated, zeroing and merging operation for the emitInsSve_Mov helper function. * Clean up codegen for embedded masked operation. * Fix SIMD&FP scalar register name in SVE emit display.
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Apr 1, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the second part of #115508, following #123717.
The mov/movprfx logic for embedded masked operations are moved from codegen into the emit functions in a similar way to #123717. The main difference is that we can use predicated movprfx (zeroing or merging) for embedded masked operations, depending on the false argument of the wrapped conditional select. This information is passed into the
emitInsSve_Movhelper using a new optionmopt, which defaults toINS_SVE_MOV_OPTS_UNPRED.@dotnet/arm64-contrib @a74nh @dhartglassMSFT