Skip to content

[tests] Add check for X86Base.IsSupported before calling X86Base.CpuId#126476

Merged
BrzVlad merged 2 commits intodotnet:mainfrom
BrzVlad:fix-clrinterp-hw-test
Apr 6, 2026
Merged

[tests] Add check for X86Base.IsSupported before calling X86Base.CpuId#126476
BrzVlad merged 2 commits intodotnet:mainfrom
BrzVlad:fix-clrinterp-hw-test

Conversation

@BrzVlad
Copy link
Copy Markdown
Member

@BrzVlad BrzVlad commented Apr 2, 2026

This test was falling on interpreter with PlatformNotSupportedException

This test was falling on interpreter with PlatformNotSupportedException
Copilot AI review requested due to automatic review settings April 2, 2026 16:49
@BrzVlad BrzVlad requested a review from tannergooding April 2, 2026 16:49
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@BrzVlad BrzVlad changed the title [tests] Add check for X86Base.IsSupported before caling X86Base.CpuId [tests] Add check for X86Base.IsSupported before calling X86Base.CpuId Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates an AVX-512 BMM hardware intrinsics test to avoid PlatformNotSupportedException when running under an interpreter by ensuring X86Base.CpuId is only called when X86Base is supported.

Changes:

  • Added an X86Base.IsSupported early-return guard before calling X86Base.CpuId in CheckSupported().

Comment thread src/tests/JIT/HardwareIntrinsics/X86_Avx512/Avx512Bmm/HandwrittenProgram.cs Outdated
…tenProgram.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 2, 2026 16:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@BrzVlad BrzVlad merged commit 9fd3ebb into dotnet:main Apr 6, 2026
102 checks passed
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Apr 9, 2026
dotnet#126476)

This test was falling on interpreter with PlatformNotSupportedException

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants