Skip to content

Update THIRD-PARTY-NOTICES.TXT with opentelemetry license#126670

Merged
danmoseley merged 1 commit intomainfrom
MiYanni-patch-1
Apr 11, 2026
Merged

Update THIRD-PARTY-NOTICES.TXT with opentelemetry license#126670
danmoseley merged 1 commit intomainfrom
MiYanni-patch-1

Conversation

@MiYanni
Copy link
Copy Markdown
Member

@MiYanni MiYanni commented Apr 8, 2026

Related: dotnet/sdk#53181

Summary

In the SDK repo, we've transitioned to OpenTelemetry (OTel) for providing telemetry in the dotnet CLI. I was told that we need to make the TPN in the dotnet installer have the information for OTel. I believe this is the right TPN file to update.

Added licensing information for opentelemetry-dotnet.
Copilot AI review requested due to automatic review settings April 8, 2026 22:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the dotnet installer package third-party notices to include the Apache 2.0 license notice for OpenTelemetry .NET, aligning the installer’s TPN with the dotnet CLI’s transition to OpenTelemetry-based telemetry.

Changes:

  • Add a new license notice section for opentelemetry-dotnet (OpenTelemetry .NET) to the installer’s THIRD-PARTY-NOTICES.TXT.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126670

Holistic Assessment

Motivation: The dotnet SDK has transitioned to OpenTelemetry for CLI telemetry (dotnet/sdk#53181), and the installer's third-party notices file needs to include the OTel license. The root THIRD-PARTY-NOTICES.TXT already has an opentelemetry-dotnet entry (lines 93–100), but the installer package's copy at src/installer/pkg/THIRD-PARTY-NOTICES.TXT did not — this PR adds it there.

Approach: Appending a new license block to the end of the installer TPN file is the standard approach and requires no code changes. The Apache 2.0 notice text is accurate, correctly attributed to "The OpenTelemetry Authors," and links to the correct upstream repository.

Summary: ⚠️ Needs Human Review. The license content itself is correct and properly formatted. However, the author explicitly notes uncertainty ("I believe this is the right TPN file to update"), and a maintainer should confirm that src/installer/pkg/THIRD-PARTY-NOTICES.TXT is the correct target for SDK-level OTel dependencies flowing through the installer.


Detailed Findings

✅ License Content Accuracy

The Apache License 2.0 boilerplate is correct and matches the opentelemetry-dotnet LICENSE. Copyright holder ("The OpenTelemetry Authors") and repository URL are accurate. The file ends with a proper newline.

✅ No Public API Surface Changes

This is a documentation-only change with no code, no public API, and no risk of behavioral regression.

⚠️ Correct Target File — Needs Maintainer Confirmation

The author states: "I believe this is the right TPN file to update." There are four THIRD-PARTY-NOTICES.TXT files in the repo:

  • ./THIRD-PARTY-NOTICES.TXT (root — already has an opentelemetry entry)
  • ./src/installer/pkg/THIRD-PARTY-NOTICES.TXT (this PR's target)
  • ./src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/THIRD-PARTY-NOTICES.TXT
  • ./src/mono/mono/mini/THIRD-PARTY-NOTICES.TXT

A maintainer familiar with installer packaging should confirm this is the file that ships with the dotnet installer and that it is the right place for SDK-level OTel dependency attribution. This is advisory — not merge-blocking — but worth explicit confirmation given the author's stated uncertainty.

💡 Minor: Header Naming Style

The new entry uses License for opentelemetry-dotnet (URL) while 56 of 60 existing entries in this file use License notice for X. Only 3 prior entries use the License for X (URL) pattern (e.g., fastmod at line 631). This is consistent with an established minority pattern so it's not incorrect, but aligning with the majority License notice for convention would be more consistent. Very low priority.

Generated by Code Review for issue #126670 ·

@danmoseley
Copy link
Copy Markdown
Member

It's already in the root but does no harm here also

@danmoseley danmoseley enabled auto-merge (squash) April 11, 2026 23:02
@danmoseley danmoseley merged commit 0145718 into main Apr 11, 2026
91 checks passed
@danmoseley danmoseley deleted the MiYanni-patch-1 branch April 11, 2026 23:03
@MiYanni
Copy link
Copy Markdown
Member Author

MiYanni commented Apr 13, 2026

It's already in the root but does no harm here also

From what I'm told, the TPN at the root of this repo does not end up in the product. We need OTel to be declared within the product itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants