Update THIRD-PARTY-NOTICES.TXT with opentelemetry license#126670
Update THIRD-PARTY-NOTICES.TXT with opentelemetry license#126670danmoseley merged 1 commit intomainfrom
Conversation
Added licensing information for opentelemetry-dotnet.
There was a problem hiding this comment.
Pull request overview
Updates the dotnet installer package third-party notices to include the Apache 2.0 license notice for OpenTelemetry .NET, aligning the installer’s TPN with the dotnet CLI’s transition to OpenTelemetry-based telemetry.
Changes:
- Add a new license notice section for
opentelemetry-dotnet(OpenTelemetry .NET) to the installer’sTHIRD-PARTY-NOTICES.TXT.
|
Note This review was generated by Copilot. 🤖 Copilot Code Review — PR #126670Holistic AssessmentMotivation: The dotnet SDK has transitioned to OpenTelemetry for CLI telemetry (dotnet/sdk#53181), and the installer's third-party notices file needs to include the OTel license. The root Approach: Appending a new license block to the end of the installer TPN file is the standard approach and requires no code changes. The Apache 2.0 notice text is accurate, correctly attributed to "The OpenTelemetry Authors," and links to the correct upstream repository. Summary: Detailed Findings✅ License Content AccuracyThe Apache License 2.0 boilerplate is correct and matches the opentelemetry-dotnet LICENSE. Copyright holder ("The OpenTelemetry Authors") and repository URL are accurate. The file ends with a proper newline. ✅ No Public API Surface ChangesThis is a documentation-only change with no code, no public API, and no risk of behavioral regression.
|
|
It's already in the root but does no harm here also |
From what I'm told, the TPN at the root of this repo does not end up in the product. We need OTel to be declared within the product itself. |
Related: dotnet/sdk#53181
Summary
In the SDK repo, we've transitioned to OpenTelemetry (OTel) for providing telemetry in the dotnet CLI. I was told that we need to make the TPN in the dotnet installer have the information for OTel. I believe this is the right TPN file to update.