Revert "Workaround for a bug in latest MSVC"#126742
Merged
AaronRobinsonMSFT merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
This reverts commit fc8c68f.
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a previously added MSVC-specific workaround in CoreCLR’s DAC/DBI implementation, restoring the original compilation/optimization behavior for the affected code path.
Changes:
- Removes the
_MSC_VER-guarded#pragma optimize("", off/on)block that wrapped theGetILCodeAndSigarea indacdbiimpl.cpp.
Member
Author
|
This fix was released ~6 months ago. |
EgorBo
approved these changes
Apr 10, 2026
AaronRobinsonMSFT
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #120282