Remove unused AssemblySpecHash class#126761
Merged
elinor-fung merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/c56ec791-9666-4079-a195-ef8a88686ec6 Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
elinor-fung
April 10, 2026 19:02
View session
Contributor
|
Tagging subscribers to this area: @agocke, @elinor-fung |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused AssemblySpecHash helper from CoreCLR’s assembly binding implementation, keeping the existing AssemblySpecBindingCache behavior intact.
Changes:
- Removed the
AssemblySpecHashclass definition fromassemblyspec.hpp. - Removed
AssemblySpecHash’s destructor andCompareSpecsimplementation fromassemblyspec.cpp. - Retained
INITIAL_ASM_SPEC_HASH_SIZEsince it is still used byAssemblySpecBindingCache.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/coreclr/vm/assemblyspec.hpp |
Deletes the unused AssemblySpecHash type while keeping the shared initial hash size constant. |
src/coreclr/vm/assemblyspec.cpp |
Removes the now-dead AssemblySpecHash method implementations. |
jkotas
approved these changes
Apr 10, 2026
AaronRobinsonMSFT
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AssemblySpecHashhas no callers anywhere in the codebase. Remove the class definition fromassemblyspec.hppand its two method implementations (~AssemblySpecHash,CompareSpecs) fromassemblyspec.cpp.The
INITIAL_ASM_SPEC_HASH_SIZEmacro is retained as it is still used byAssemblySpecBindingCache.cc @dotnet/appmodel @AaronRobinsonMSFT