Fix result assignment after action execution#126766
Merged
AaronRobinsonMSFT merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
Ensure result is set to TestPassed only after action execution.
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the STA-thread test harness so the exit code is only set to TestPassed after the provided action completes successfully (and is not incorrectly overwritten after a failure).
Changes:
- Move
result = TestPassed;into thetryblock afteraction()executes. - Ensure exceptions (including assertion failures) keep
resultasTestFailed.
Show a summary per file
| File | Description |
|---|---|
src/tests/Interop/COM/NETClients/Lifetime/Program.cs |
Corrects RunOnSTAThread result assignment so failures aren’t overwritten as passes. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
elinor-fung
approved these changes
Apr 10, 2026
jkoritzinsky
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure result is set to TestPassed only after action execution.