[QUIC] Remove check for AzL3 for QUIC and H/3 tests#126834
Open
ManickaP wants to merge 1 commit intodotnet:mainfrom
Open
[QUIC] Remove check for AzL3 for QUIC and H/3 tests#126834ManickaP wants to merge 1 commit intodotnet:mainfrom
ManickaP wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Azure Linux 3 VM-specific test gating that was added due to MsQuic failures, with the intent of re-enabling QUIC and HTTP/3 test execution now that SymCrypt images are expected to be updated.
Changes:
- Remove
IsNotAzureLinux3VMconditions from System.Net.Quic functional test classes. - Remove the
IsNotAzureLinux3VMcheck fromHttpClientHandlerTestBase.IsHttp3Supported. - Delete the
IsNotAzureLinux3VMhelper properties that implemented the AzL3 skip logic.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs | Removes the IsNotAzureLinux3VM helper used to skip AzL3 VMs. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs | Drops AzL3 from the ConditionalClass gating list. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamConnectedStreamConformanceTests.cs | Drops AzL3 from the ConditionalClass gating list. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs | Drops AzL3 from the ConditionalClass gating list. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs | Drops AzL3 from the ConditionalClass gating list. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs | Drops AzL3 from the ConditionalClass gating list. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs | Drops AzL3 from the ConditionalClass gating list. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs | Attempts to remove AzL3 gating, but introduces an invalid ConditionalClass usage (see comment). |
| src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicCipherSuitesPolicyTests.cs | Drops AzL3 from the ConditionalClass gating list. |
| src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTestBase.SocketsHttpHandler.cs | Removes the AzL3 gating from HTTP/3 support detection and deletes the helper property. |
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs
Show resolved
Hide resolved
wfurt
approved these changes
Apr 13, 2026
This was referenced Apr 13, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123216
SymCrypt 1.9.5 is out, docker images are already fixed, let's see if the base VM images are up-to-date or need re-building.