Skip to content

Add DelegateDataFlow tests for DynamicallyAccessedMembers analysis on delegate fields/properties#126918

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/add-dynamically-accessed-members-tests
Draft

Add DelegateDataFlow tests for DynamicallyAccessedMembers analysis on delegate fields/properties#126918
Copilot wants to merge 4 commits intomainfrom
copilot/add-dynamically-accessed-members-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

  • Create DelegateDataFlow.cs test case file with tests for DAM analysis on delegate fields, properties, and invocation
  • Add corresponding test entry in DataFlowTests.cs for the Roslyn analyzer
  • Fix all ExpectedWarning attributes to match actual ILLink warning messages (use "Invoke" not field/property names)
  • Remove dead GenericDelegateWithAnnotatedTypeParameter class (DAM on generic type params doesn't propagate to Invoke)
  • Fix formatting to match sibling test conventions (4 spaces, no space before parens)
  • ILLink trimmer tests — PASSED
  • Roslyn analyzer tests — PASSED
  • NativeAOT — uses same shared test infrastructure; infrastructure requires aotsdk build artifacts
  • Run parallel validation — Code Review ✅, CodeQL ✅

Copilot AI and others added 4 commits April 14, 2026 20:40
… delegate fields/properties

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f8d36913-1346-4f8d-8514-eb398ffbc0e1

Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
…elegate test class

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/346454a4-d1ec-4c38-b03e-d5d6f8fa0155

Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
…ce before parens)

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/346454a4-d1ec-4c38-b03e-d5d6f8fa0155

Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 14, 2026 23:11
Copilot AI review requested due to automatic review settings April 14, 2026 23:11
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Apr 14, 2026
Copilot AI requested a review from jtschuster April 14, 2026 23:12
@github-actions github-actions bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Apr 14, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/illink
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants