Add failing ILTrim tests to baseline#126923
Conversation
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Weird, we did run the ILTrim tests on that PR and the results were only 5 days old:
2026-04-09T23:08:38.7818259Z Running tests: /__w/1/s/artifacts/bin/ILTrim.Tests/x64/Checked/ILTrim.Tests.dll [net11.0|x64]
2026-04-09T23:10:17.8033735Z Tests succeeded: /__w/1/s/artifacts/bin/ILTrim.Tests/x64/Checked/ILTrim.Tests.dll [net11.0|x64]
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Oh, wait, where is the list of failing tests coming from?
Pulling down the logs from https://dev.azure.com/dnceng-public/public/_build/results?buildId=1378629&view=artifacts&pathAsName=false&type=publishedArtifacts:
Test Run Failed.
Total tests: 912
Passed: 286
Failed: 1
Skipped: 625
Total time: 1.7779 Minutes
Failed Generics.GenericConstraints [47 ms]
Error Message:
Assert.Fail failed. Type `System.Runtime.CompilerServices.IsUnmanagedAttribute' should have been kept
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraint/TestClass::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraint/TestClass::.cctor()' should have been removed
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraintOnMethod/TestClass::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraintOnMethod/TestClass::.cctor()' should have been removed
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/StructConstraint/TestStruct::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/StructConstraint/TestStruct::.cctor()' should have been removed
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/UnmanagedConstraint/TestStruct::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/UnmanagedConstraint/TestStruct::.cctor()' should have been removed
Missing custom attributes on `generic parameter 'T' of Mono.Linker.Tests.Cases.Generics.GenericConstraints/UnmanagedConstraint/WithConstraint`1`:
System.Runtime.CompilerServices.IsUnmanagedAttribute
That one looks expected.
Removed several unused attributes and warnings from expected failures list.
The CI was failing because we also check the tests in ExpectedFailures are actually failing and they were not. Updated it to just the one test, we'll see. |
Ah, thanks - my original list was failing locally due to missing ilasm, but that was unrelated to the ci failure. |
|
/ba-g remaining legs are on track to time out and they are not interesting |
Failing in main, hit in #123040.