Remove obsolete DacDbi APIs and simplify RCW cached type query path#126962
Merged
Remove obsolete DacDbi APIs and simplify RCW cached type query path#126962
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f4148341-faeb-4cd2-9cdb-f7e16227b1a3 Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rcj1
April 15, 2026 18:03
View session
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
rcj1
added
NO-REVIEW
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/fe4d3ebd-7c52-4726-85eb-9802ed9e1ebd Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes obsolete IDacDbiInterface APIs (NGEN / ReJit / legacy RCW interface type enumeration) and simplifies the RCW cached interface type query path to avoid unnecessary DAC calls.
Changes:
- Deleted several unused/obsolete
IDacDbiInterfacemethods across the IDL, native headers, native implementation, and managed COM interop surface. - Simplified
CordbObjectValue::GetCachedInterfaceTypesto directly return an empty enumerator (matching prior “always empty” behavior). - Removed a now-obsolete test that validated
EnableNGENPolicyreturningE_NOTIMPL.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiAppDomainDumpTests.cs | Removes the EnableNGENPolicy test now that the API is deleted. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs | Drops obsolete methods from the managed COM interop interface. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs | Removes obsolete wrapper methods corresponding to deleted interface entries. |
| src/coreclr/inc/dacdbi.idl | Removes obsolete methods from the COM IDL surface. |
| src/coreclr/debug/inc/dacdbiinterface.h | Removes obsolete methods from the native interface definition. |
| src/coreclr/debug/di/process.cpp | Simplifies GetDesiredNGENCompilerFlags to return CORDBG_E_NGEN_NOT_SUPPORTED directly. |
| src/coreclr/debug/di/divalue.cpp | Removes DAC-based RCW interface type enumeration; returns an empty type enumerator. |
| src/coreclr/debug/daccess/dacdbiimpl.h | Removes obsolete method declarations from DacDbiInterfaceImpl. |
| src/coreclr/debug/daccess/dacdbiimpl.cpp | Removes obsolete method implementations from DacDbiInterfaceImpl. |
hoyosjs
approved these changes
Apr 16, 2026
Contributor
|
/ba-g unrelated wasm failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.