Implement cDAC-backed DacDbi GetObjectForCCW and IsRcw + dump integration coverage#126963
Merged
Implement cDAC-backed DacDbi GetObjectForCCW and IsRcw + dump integration coverage#126963
GetObjectForCCW and IsRcw + dump integration coverage#126963Conversation
…9fb-4c74-a840-d9c748b9f2a3 Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/3366f85c-89fb-4c74-a840-d9c748b9f2a3 Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/3366f85c-89fb-4c74-a840-d9c748b9f2a3 Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com> add interop APIs
Copilot created this pull request from a session on behalf of
rcj1
April 15, 2026 18:31
View session
rcj1
changed the title
GetObjectForCCW and IsRcw + Windows dump integration coverageGetObjectForCCW and IsRcw + dump integration coverage
Contributor
There was a problem hiding this comment.
Pull request overview
Implements missing DacDbiImpl COM-related APIs (GetObjectForCCW, IsRcw) on the cDAC-backed path and adds Windows-focused dump integration tests to validate COM interop scenarios (BuiltIn COM + ComWrappers) against real dumps.
Changes:
- Implement
DacDbiImpl.GetObjectForCCWusing ComWrappers-first resolution with BuiltIn COM fallback. - Implement
DacDbiImpl.IsRcwusingIObject.GetBuiltInComData(...)RCW presence. - Add dump-based integration tests for CCW → managed object handle (BuiltIn COM + ComWrappers) and RCW classification.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs | Adds cDAC-backed implementations for GetObjectForCCW and IsRcw, with DEBUG cross-validation vs legacy DAC. |
| src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiCCWDumpTests.cs | Adds Windows-only dump test validating BuiltIn COM CCW/interface-pointer → object-handle resolution. |
| src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiComWrappersDumpTests.cs | Adds dump test validating ComWrappers identity-pointer → managed object wrapper handle resolution. |
| src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiRCWDumpTests.cs | Adds Windows-only dump tests validating IsRcw returns true for RCWs and false for non-RCWs. |
noahfalk
approved these changes
Apr 16, 2026
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
LGTM
Adding @jkoritzinsky for all things COM :)
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
The comment from Copilot concerns me. Other than that, looks good!
jkoritzinsky
approved these changes
Apr 16, 2026
rcj1
removed request for
BrzVlad,
MichalStrehovsky,
akoeplinger,
ilonatommy,
janvorli,
jeffhandley,
kg,
lateralusX,
lewing and
maraf
dotnet-policy-service
Bot
added
the
linkable-framework
rcj1
removed
the
linkable-framework
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement DacDbi APIs GetObjectForCCW and IsRcw based on existing cDAC contracts