Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public class ServiceProviderCompilationTest
[InlineData(ServiceProviderMode.ILEmit, typeof(I999))]
[InlineData(ServiceProviderMode.Expressions, typeof(I999))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/33894", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
private async Task CompilesInLimitedStackSpace(ServiceProviderMode mode, Type serviceType)
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is marked with [Theory]/[InlineData] but is declared private. xUnit test methods are expected to be public in this repo; as-written, the test cases may not be discovered/executed (and the new [ActiveIssue] won’t have any effect). Consider making the method public (or adding a public wrapper) so it actually runs.

Suggested change
private async Task CompilesInLimitedStackSpace(ServiceProviderMode mode, Type serviceType)
public async Task CompilesInLimitedStackSpace(ServiceProviderMode mode, Type serviceType)

Copilot uses AI. Check for mistakes.
{
// Arrange
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#if ROSLYN4_8_OR_GREATER

using System;
using System.Collections.Immutable;
using System.Linq;
using Microsoft.CodeAnalysis;
Expand All @@ -17,6 +18,7 @@ public class LoggerMessageGeneratorIncrementalTests
new GeneratorDriverOptions(IncrementalGeneratorOutputKind.None, trackIncrementalGeneratorSteps: true);

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void AddingNewUnrelatedType_DoesNotRegenerateSource()
{
string source = """
Expand Down Expand Up @@ -55,6 +57,7 @@ partial class C
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void AppendingUnrelatedSource_DoesNotRegenerateSource()
{
string source = """
Expand Down Expand Up @@ -100,6 +103,7 @@ partial class C
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void AddingNewLoggerMessageMethod_DoesNotRegenerateExistingMethod()
{
string source1 = """
Expand Down Expand Up @@ -154,6 +158,7 @@ partial class D
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void ChangingLoggerMessageAttribute_RegeneratesMethod()
{
string source1 = """
Expand Down Expand Up @@ -203,6 +208,7 @@ partial class C
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void ChangingUnrelatedMethodBody_DoesNotRegenerateLoggerMessage()
{
string source1 = """
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ public void CreateDirectory_LongPath()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void CurrentDirectoryGet()
{
var CurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand All @@ -294,6 +295,7 @@ public void CurrentDirectoryGet()

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void CurrentDirectorySet()
{
var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ public void IEnumerable_GetAllExpectedItems()

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/16413", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void ReferenceTypes_NulledAfterDequeue()
{
int iterations = 10; // any number <32 will do
Expand Down Expand Up @@ -277,6 +278,7 @@ public void ManySegments_ConcurrentDequeues_RemainsConsistent()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void ManySegments_ConcurrentEnqueues_RemainsConsistent()
{
var cq = new ConcurrentQueue<int>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Globalization;
using System.Linq;
using System.Runtime.Serialization;
using Microsoft.DotNet.XUnitExtensions;
using Xunit;

namespace System.Collections.Tests
Expand Down Expand Up @@ -774,7 +775,7 @@ public void Dictionary_GetAlternateLookup_OperationsMatchUnderlyingDictionary(IE
#endregion

#region Non-randomized comparers
[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
public void Dictionary_Comparer_NonRandomizedStringComparers()
{
RunTest(null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ public class InternalHashCodeTests_OrderedDictionary_LinguisticComparer : Intern
}
#endregion

[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public abstract class InternalHashCodeTests<TCollection>
{
protected static Type nonRandomizedOrdinalComparerType = typeof(object).Assembly.GetType("System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer", throwOnError: true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace System.Collections.Tests
{
public static class HashSet_NonGeneric_Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
[Fact]
public static void HashSet_CopyConstructor_ShouldWorkWithRandomizedEffectiveComparer()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public void TestBackgroundWorkerBasic()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public async Task RunWorkerAsync_NoOnWorkHandler_SetsResultToNull()
{
var tcs = new TaskCompletionSource();
Expand Down Expand Up @@ -326,6 +327,7 @@ public void DisposeTwiceShouldNotThrow()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void TestFinalization()
{
// BackgroundWorker has a finalizer that exists purely for backwards compatibility
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void CanBeFinalized()
{
FinalizingCommand.CreateAndRelease();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ private class TestDbProviderFactory : DbProviderFactory
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void CanBeFinalized()
{
FinalizingConnection.CreateAndRelease();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public void IsSupported()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void StartStopCreatesActivity()
{
using ActivityEventListener l = new ActivityEventListener();
Expand All @@ -67,6 +68,7 @@ public void StartStopCreatesActivity()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public async Task ActivityFlowsAsync()
{
using ActivityEventListener l = new ActivityEventListener();
Expand Down Expand Up @@ -115,6 +117,7 @@ private async Task YieldTwoActivitiesDeep(ActivityEventSource es)
// the future we might decide it wasn't even desirable to begin with.
// Compare with SetCurrentActivityIdAfterEventDoesNotFlowAsync below.
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public async Task SetCurrentActivityIdBeforeEventFlowsAsync()
{
using ActivityEventListener l = new ActivityEventListener();
Expand All @@ -140,6 +143,7 @@ public async Task SetCurrentActivityIdBeforeEventFlowsAsync()
// the future we might decide it wasn't even desirable to begin with.
// Compare with SetCurrentActivityIdBeforeEventFlowsAsync above.
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public async Task SetCurrentActivityIdAfterEventDoesNotFlowAsync()
{
using ActivityEventListener l = new ActivityEventListener();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ namespace System.IO.Compression.Tests
public partial class ZipFile_Unix : ZipFileTestBase
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void UnixCreateSetsPermissionsInExternalAttributes()
{
// '7600' tests that S_ISUID, S_ISGID, and S_ISVTX bits get preserved in ExternalAttributes
Expand Down Expand Up @@ -70,6 +71,7 @@ public void UnixCreateSetsPermissionsInExternalAttributesUMaskZero()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void UnixExtractSetsFilePermissionsFromExternalAttributes()
{
// '7600' tests that S_ISUID, S_ISGID, and S_ISVTX bits don't get extracted to file permissions
Expand Down Expand Up @@ -173,6 +175,7 @@ public static IEnumerable<object[]> Get_UnixExtractFilePermissionsCompat_Data()

[Theory]
[MemberData(nameof(Get_UnixExtractFilePermissionsCompat_Data))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public async Task UnixExtractFilePermissionsCompat(string zipName, string expectedPermissions, bool async)
{
expectedPermissions = GetExpectedPermissions(expectedPermissions);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

namespace System.Net.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public class ServicePointManagerTest
{
[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ namespace System.Net.Tests
public class TlsSystemDefault
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void ServicePointManager_SecurityProtocolDefault_Ok()
{
Assert.Equal(SecurityProtocolType.SystemDefault, ServicePointManager.SecurityProtocol);
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void ServicePointManager_CheckAllowedProtocols_SystemDefault_Allowed()
{
SecurityProtocolType orig = ServicePointManager.SecurityProtocol;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ namespace System.Runtime.InteropServices.Tests
public partial class ComVariantMarshallerTests
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void Null_Marshals_To_Empty()
{
Assert.Equal(VarEnum.VT_EMPTY, ComVariantMarshaller.ConvertToUnmanaged(null).VarType);
Assert.Null(ComVariantMarshaller.ConvertToManaged(default));
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void DBNull_Marshals_To_Null()
{
Assert.Equal(VarEnum.VT_NULL, ComVariantMarshaller.ConvertToUnmanaged(DBNull.Value).VarType);
Expand Down Expand Up @@ -265,6 +267,7 @@ public void Decimal_Marshals_To_DECIMAL(decimal value)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void Date_Marshals_To_DATE()
{
// OLE dates do not have time zones and do not support sub-millisecond precision.
Expand Down Expand Up @@ -309,7 +312,8 @@ public void Method() { }
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55742", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
Comment thread
radekdoulik marked this conversation as resolved.
[ActiveIssue("https://github.com/dotnet/runtime/issues/55742", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime))]
public unsafe void GeneratedComInterfaceType_Marshals_To_UNKNOWN()
{
var obj = new ComExposedType();
Expand All @@ -326,6 +330,7 @@ public unsafe void GeneratedComInterfaceType_Marshals_To_UNKNOWN()

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55742", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void UnknownWrapper_Of_GeneratedComInterfaceType_Marshals_To_UNKNOWN()
{
var obj = new ComExposedType();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,14 @@ public void VariantBoolFalse()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void VTVariantNotSupported()
{
Assert.Throws<ArgumentException>("vt", () => ComVariant.CreateRaw(VarEnum.VT_VARIANT, 1));
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltInComEnabled))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void Unknown_NotSupported()
{
UnknownWrapper wrapper = new(new TestObject());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public class AddRefTests
[Fact]
[SkipOnMono("ComWrappers are not supported on Mono")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/76005", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot), nameof(PlatformDetection.IsNotWindows))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void AddRef_ValidPointer_Success()
{
var cw = new ComWrappersImpl();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static IEnumerable<object[]> QueryInterface_ValidInterface_TestData()
[MemberData(nameof(QueryInterface_ValidInterface_TestData))]
[SkipOnMono("ComWrappers are not supported on Mono")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/76005", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot), nameof(PlatformDetection.IsNotWindows))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void QueryInterface_ValidInterface_Success(object o, string iidString)
{
var cw = new ComWrappersImpl();
Expand Down Expand Up @@ -57,6 +58,7 @@ public static IEnumerable<object[]> QueryInterface_NoSuchInterface_TestData()
[MemberData(nameof(QueryInterface_NoSuchInterface_TestData))]
[SkipOnMono("ComWrappers are not supported on Mono")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/76005", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot), nameof(PlatformDetection.IsNotWindows))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void QueryInterface_NoSuchInterface_Success(object o, string iidString)
{
var cw = new ComWrappersImpl();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public class ReleaseTests
[Fact]
[SkipOnMono("ComWrappers are not supported on Mono")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/76005", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot), nameof(PlatformDetection.IsNotWindows))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void Release_ValidPointer_Success()
{
var cw = new ComWrappersImpl();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
namespace System.Runtime.Intrinsics.Wasm.Tests
{
[PlatformSpecific(TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public sealed class PackedSimdTests
{
[Fact]
Expand Down
Loading
Loading