Skip to content

Remove _DbgBreakCheck calls from the JIT #127052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −18
Open

Remove _DbgBreakCheck calls from the JIT #127052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/coreclr/jit/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6614,24 +6614,6 @@ void Compiler::compCompileFinish()
}
#endif // TRACK_ENREG_STATS

// Only call _DbgBreakCheck when we are jitting, not when we are generating AOT code.
// For AOT the int3 or breakpoint instruction will be right at the
// start of the AOT method and we will stop when we execute it.
//
if (!IsAot())
{
if (compJitHaltMethod())
{
#if !defined(HOST_UNIX)
// TODO-UNIX: re-enable this when we have an OS that supports a pop-up dialog

// Don't do an assert, but just put up the dialog box so we get just-in-time debugger
// launching. When you hit 'retry' it will continue and naturally stop at the INT 3
// that the JIT put in the code
_DbgBreakCheck(__FILE__, __LINE__, "JitHalt");
#endif
}
}
#else // DEBUG
if (JitConfig.JitReportMetrics())
{
Expand Down
Loading