[ios-clr] Update IsMetadataUpdateSupported to aggressive trimming instead of NativeAOT#127055
Open
kotlarmilos wants to merge 1 commit intodotnet:mainfrom
Open
[ios-clr] Update IsMetadataUpdateSupported to aggressive trimming instead of NativeAOT#127055kotlarmilos wants to merge 1 commit intodotnet:mainfrom
kotlarmilos wants to merge 1 commit intodotnet:mainfrom
Conversation
…d of NativeAOT update (EnC / hot reload) actually relies on reflection metadata preserved by the trimmer. Aggressively-trimmed CoreCLR apps on Apple mobile hit the same limitation. Base the check on ReflectionCacheTests.InvokeClearCache_NoExceptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts library test gating so metadata update–dependent tests are skipped on platforms where aggressive trimming makes metadata updates unsupported (not just on NativeAOT). This helps stabilize CoreCLR test runs on Apple mobile targets as part of the larger iOS CLR test-fix effort.
Changes:
- Update
PlatformDetection.IsMetadataUpdateSupportedto depend on!IsBuiltWithAggressiveTrimming. - Remove a now-redundant
ActiveIssueskip inReflectionCacheTests(Apple mobile + CoreCLR), relying on the updated conditional skip instead.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs |
Re-defines IsMetadataUpdateSupported to reflect aggressive trimming (covers Apple mobile) rather than only NativeAOT. |
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/ReflectionCacheTests.cs |
Removes an ActiveIssue attribute now superseded by ConditionalFact(IsMetadataUpdateSupported). |
kotlarmilos
changed the title
Contributor
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Apr 17, 2026
This was referenced Apr 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates IsMetadataUpdateSupported to aggressive trimming instead of Native AOT to avoid using ActiveIssue for Apple mobile tests that are not supported.