Fix gc hole when resuming async continuation via interpreter#127072
Open
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Open
Fix gc hole when resuming async continuation via interpreter#127072BrzVlad wants to merge 1 commit intodotnet:mainfrom
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Conversation
AsyncHelpers_ResumeInterpreterContinuationWorker receives an interior pointer that was not reported to the GC. It seems like this issue was happening only in InterpMode=1. It is likely that in full interpreter mode, the continuation object was conservatively pinned by chance from the interpreter stack. Fixes random crashes in objects-captured runtime test.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a GC reporting hole when resuming async continuations in the interpreter by ensuring an interior pointer passed from managed code is reported and updated across GC during execution (addressing random crashes seen in the objects-captured runtime test, primarily in InterpMode=1).
Changes:
- Protect
resultStorage(an interior pointer into a managed continuation object) withGCPROTECT_BEGININTERIOR/GCPROTECT_ENDwhile executing the interpreter continuation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncHelpers_ResumeInterpreterContinuationWorker receives an interior pointer that was not reported to the GC. It seems like this issue was happening only in InterpMode=1. It is likely that in full interpreter mode, the continuation object was conservatively pinned by chance from the interpreter stack.
Fixes random crashes in objects-captured runtime test.