[cDAC] Implement IsMatchingParentFrame for cDAC#127100
Closed
[cDAC] Implement IsMatchingParentFrame for cDAC#127100
Conversation
…ty check Replace the legacy-delegation stub with a direct stack pointer equality comparison, matching the native C++ semantics where ExInfo::IsUnwoundToTargetParentFrame is simply sfParent == sfToCheck. Include #if DEBUG legacy cross-validation following the IsValueType pattern. Add [cDAC] annotation to the native C++ implementation. Add unit tests covering equal, different, zero, and max value frame pointers. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/bdff63a2-7448-46cb-8c0e-ffa04ae69ec8 Co-authored-by: barosiak <76071368+barosiak@users.noreply.github.com>
…data points Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/bdff63a2-7448-46cb-8c0e-ffa04ae69ec8 Co-authored-by: barosiak <76071368+barosiak@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
|
Hey, I just put up a PR such that we won’t need this API: #127099 |
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement IsMatchingParentFrame on DacDbiImpl in the cDAC.
Changes