Fix xplat dump test OOM by splitting Helix payloads#127108
Open
max-charlamb wants to merge 1 commit intomainfrom
Open
Fix xplat dump test OOM by splitting Helix payloads#127108max-charlamb wants to merge 1 commit intomainfrom
max-charlamb wants to merge 1 commit intomainfrom
Conversation
The xplat dump tests were hitting OutOfMemoryException when the Helix SDK tried to zip all platforms' dumps into a single MemoryStream-backed ZipArchive, exceeding the 2GB byte[] limit. Fix by splitting payloads: - Test DLLs: sent as a correlation payload (shared, uploaded once) - Dumps: sent as per-work-item payloads (one platform per work item) This avoids the single large zip and reduces redundant uploads since test DLLs are no longer duplicated across work items. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses out-of-memory failures in the cDAC x-plat dump Helix test flow by avoiding creation of a single massive in-memory zip payload when multiple platforms’ dumps are included together.
Changes:
- Split Helix payloads so platform dumps are uploaded as per-work-item payloads (one platform per work item).
- Upload test binaries as a Helix correlation payload shared across all work items.
- Update the runtime-diagnostics pipeline to pass the new payload parameters (
TestPayload,DumpPayloadBase) to the Helix project.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/managed/cdac/tests/DumpTests/cdac-dump-xplat-test-helix.proj | Moves test assets to correlation payload and switches each work item to upload only its platform’s dump directory. |
| eng/pipelines/runtime-diagnostics.yml | Updates Helix send parameters to provide separate test and dump payload paths for the x-plat dump test stage. |
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix OOM in xplat dump tests by splitting Helix payloads so that multi-platform dumps are not zipped into a single MemoryStream-backed archive.
Problem
The Helix SDK uses
DirectoryPayload.DoUploadAsyncwhich zips entire directories into aMemoryStream-backedZipArchive. When xplat dump tests include dumps from all platforms (linux-x64, linux-arm64, windows-x64, windows-x86, windows-arm64), the combined size exceeds the ~2GBbyte[]limit ofMemoryStream, causing anOutOfMemoryExceptionregardless of process bitness.Fix
Split the Helix payload into:
This keeps each individual zip well under the 2GB limit and also reduces total upload size since test binaries are no longer duplicated per work item.
Testing