arm64: Clean up SVE embedded masked codegen#127164
Draft
ylpoonlg wants to merge 1 commit intodotnet:mainfrom
Draft
arm64: Clean up SVE embedded masked codegen#127164ylpoonlg wants to merge 1 commit intodotnet:mainfrom
ylpoonlg wants to merge 1 commit intodotnet:mainfrom
Conversation
* Move the embedded masked block to a new function. * Combine codepaths for different number of operand cases. * Optimise predicated movprfx into unpredicated movprfx when mask is all-true. * Allow zero falseOp to be contained when mask is not all-true. * Fix Sve HWIntrin tests ConditionalSelect ZeroOp. The zero vector needs to be passed directly as constant such that the falseOp->IsVectorZero branch can be tested. * Fix LSRA delay free to allow unary embedded masked ops to use movprfx.
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the last part for #115508, with the following changes:
Cleanup to
hwintrinsiccodegenarm64.cpp:genEmbeddedMaskedHWIntrinsic.Optimizations to movprfx usage in embedded masked operation codegen:
Fixing the Sve HardwareIntrinsics tests
ConditionalSelect_ZeroOpcalls: ThefalseOp->IsVectorZerobranch in the codegen was previously untested because the zero vector was passed as a local variable rather than a constant vector. The zero vector needs to be passed directly into theConditionalSelectintrinsic in the test templates.