[wasm][coreclr] Fix native relinking#127177
Merged
radekdoulik merged 2 commits intodotnet:mainfrom Apr 21, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets the CoreCLR WASM native relink pipeline by ensuring relink-generated sources can access WASM-specific callhelper constants and required helper macros during compilation.
Changes:
- Moves the
TERMINATE_R2R_STACK_WALKsentinel definition intovm/wasm/callhelpers.hppand wires it intovm/callhelpers.hfor WASM builds. - Adds an include of
minipal/utils.hto the checked-in generatedcallhelpers-interp-to-managed.cpp(intended to provideNOINLINEfor portable-entrypoint call thunks).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/vm/wasm/callhelpers.hpp | Defines TERMINATE_R2R_STACK_WALK in the header consumed by relink-generated thunks and other WASM helpers. |
| src/coreclr/vm/wasm/callhelpers-interp-to-managed.cpp | Adds minipal/utils.h include (attempting to ensure NOINLINE is available for generated portable-entrypoint call helpers). |
| src/coreclr/vm/callhelpers.h | Includes the WASM callhelpers header under TARGET_WASM (and removes the local sentinel definition). |
davidwrighton
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix CI build and relinking, introduced in #126901 and masked by #90458 in build analysis