[browser] Disable server GC on wasm to save size#127222
Open
radekdoulik wants to merge 2 commits intodotnet:mainfrom
Open
[browser] Disable server GC on wasm to save size#127222radekdoulik wants to merge 2 commits intodotnet:mainfrom
radekdoulik wants to merge 2 commits intodotnet:mainfrom
Conversation
Wasm does not need two GC implementations. Remove server GC to reduce the binary size. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables Server GC support when building CoreCLR for WebAssembly to reduce runtime binary size, aligning WASM behavior with other constrained targets (e.g., Android) that avoid shipping multiple GC implementations.
Changes:
- Gate
FEATURE_SVR_GCso it is not enabled when targeting WASM. - Avoid defining
FEATURE_SVR_GCfor WASM builds (prevents server-GC-specific code/data from being included).
jkotas
reviewed
Apr 21, 2026
| add_definitions(-DFEATURE_ENABLE_NO_ADDRESS_SPACE_RANDOMIZATION) | ||
| endif(FEATURE_ENABLE_NO_ADDRESS_SPACE_RANDOMIZATION) | ||
| if (NOT CLR_CMAKE_HOST_ANDROID) | ||
| if (NOT CLR_CMAKE_HOST_ANDROID AND NOT CLR_CMAKE_TARGET_ARCH_WASM) |
Member
There was a problem hiding this comment.
Should we disable it for Apple iOS and tvOS too while we are on it?
Member
|
@radekdoulik there is another PR (#127178) for this that was created by @davidwrighton via @copilot before you created this one where I've also added disabling of background GC. |
This was referenced Apr 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasm does not need two GC implementations. Disable server GC to reduce the binary size, similar to how it is already disabled on Android.