Skip to content

Make PrepareTrimConfiguration a public extension point #127253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbomer wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −6
Open

Make PrepareTrimConfiguration a public extension point #127253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e79fa3
Make PrepareTrimConfiguration a public extension point
sbomer Apr 21, 2026
e190b48
Clarify comment
sbomer Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Target Name="_ComputeIlcCompileInputs"
Condition="'$(BuildingFrameworkLibrary)' != 'true'"
BeforeTargets="ComputeIlcCompileInputs"
DependsOnTargets="$(IlcDynamicBuildPropertyDependencies);_ComputeAssembliesToCompileToNative;_PrepareTrimConfiguration">
DependsOnTargets="$(IlcDynamicBuildPropertyDependencies);_ComputeAssembliesToCompileToNative;PrepareTrimConfiguration">

<ItemGroup>
<_IlcManagedInputAssemblies Include="@(ResolvedFileToPublish)" Condition="'%(ResolvedFileToPublish.PostprocessAssembly)' == 'true'" />
Expand All @@ -24,7 +24,7 @@
The SDK typically sequences this target in the publish pipeline as:
ComputeResolvedFilesToPublishList -> ILLink (when RunILLink is true) -> NativeCompile -> ...

This gives us a clean, explicit position after trim configuration (_PrepareTrimConfiguration),
This gives us a clean, explicit position after trim configuration (PrepareTrimConfiguration),
regardless of whether ILLink itself runs.
============================================================
-->
Expand Down Expand Up @@ -84,7 +84,7 @@
<UsingTask TaskName="ComputeManagedAssembliesToCompileToNative" AssemblyFile="$(IlcBuildTasksPath)" />
<Target Name="_ComputeAssembliesToCompileToNative"
DependsOnTargets="$(IlcDynamicBuildPropertyDependencies);_ComputeAssembliesToPostprocessOnPublish"
BeforeTargets="_PrepareTrimConfiguration">
BeforeTargets="PrepareTrimConfiguration">

<Warning Condition="Exists($(UserRuntimeConfig))" Text="The published project has a runtimeconfig.template.json that is not supported by PublishAot. Move the configuration to the project file using RuntimeHostConfigurationOption." />
<!-- Fail with descriptive error message for common mistake. -->
Expand Down
11 changes: 8 additions & 3 deletions src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,19 +195,24 @@ Copyright (c) .NET Foundation. All rights reserved.

<!--
============================================================
_PrepareTrimConfiguration
PrepareTrimConfiguration

Set up shared trim configuration properties and metadata on ResolvedFileToPublish.
This target is shared between ILLink and ILC (NativeAOT). It sets default values for
trim-related properties (TrimMode, TrimmerSingleWarn), populates TrimmerRootAssembly
and _TrimmerFeatureSettings, and applies TrimmerSingleWarn metadata to
ResolvedFileToPublish items for the intermediate assembly and project references.

This is a public extension point. Other targets may hook into it via
BeforeTargets="PrepareTrimConfiguration" to add RuntimeHostConfigurationOption items.
Only items with Trim="true" metadata will be included in _TrimmerFeatureSettings
for both ILLink and ILC.

Consumers that need trim metadata on ResolvedFileToPublish should depend on this target.
Metadata set here flows to ManagedAssemblyToLink via _ComputeManagedAssemblyToLink (which
depends on this target), since ComputeManagedAssemblies preserves metadata from its inputs.
-->
<Target Name="_PrepareTrimConfiguration"
<Target Name="PrepareTrimConfiguration"
DependsOnTargets="_ComputeAssembliesToPostprocessOnPublish">

Comment thread
sbomer marked this conversation as resolved.
<!-- Set up TrimMode. -->
Expand Down Expand Up @@ -335,7 +340,7 @@ Copyright (c) .NET Foundation. All rights reserved.
============================================================
-->
<UsingTask TaskName="ComputeManagedAssemblies" AssemblyFile="$(ILLinkTasksAssembly)" Condition="'$(ILLinkTasksAssembly)' != ''" TaskFactory="TaskHostFactory" />
<Target Name="_ComputeManagedAssemblyToLink" DependsOnTargets="_PrepareTrimConfiguration">
<Target Name="_ComputeManagedAssemblyToLink" DependsOnTargets="PrepareTrimConfiguration">

<!-- NB: There should not be non-managed assemblies in this list, but we still give the ILLink a chance to
further refine this list. It currently drops C++/CLI assemblies in ComputeManageAssemblies. -->
Expand Down
Loading