Adopt RuntimeFeature.IsMultithreadingSupported for CoreCLR PlatformDetection#127313
Merged
pavelsavara merged 1 commit intodotnet:mainfrom Apr 23, 2026
Merged
Conversation
…tection Replace reflection-based workaround with direct RuntimeFeature.IsMultithreadingSupported call now that the ref assemblies include the API. Fixes dotnet#124748
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/area-system-reflection |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CoreCLR test PlatformDetection to use the now-available RuntimeFeature.IsMultithreadingSupported API directly, removing the previous reflection-based workaround used for WASM multithreading detection.
Changes:
- Replace the reflection helper with
RuntimeFeature.IsMultithreadingSupported. - Remove the unused
System.Reflectionusing and the related TODO/comment block.
This was referenced Apr 23, 2026
Open
jkotas
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the reflection-based workaround in
src/tests/Common/CoreCLRTestLibrary/PlatformDetection.cswith a directRuntimeFeature.IsMultithreadingSupportedcall, now that the ref assemblies (SDK 11.0.100-preview.3) include the API.GetIsMultithreadingSupported()reflection helperusing System.ReflectionFixes #124748