Handle missing Network.framework peer certificate chain#127451
Merged
liveans merged 1 commit intodotnet:mainfrom Apr 27, 2026
Merged
Handle missing Network.framework peer certificate chain#127451liveans merged 1 commit intodotnet:mainfrom
liveans merged 1 commit intodotnet:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in Apple Network Framework TLS/WebSockets scenarios by safely handling cases where the peer certificate chain handle is missing/invalid, avoiding a NullReferenceException during remote certificate extraction.
Changes:
- Make the Network.framework peer chain handle nullable when retrieving the remote certificate.
- Early-return
nullwhen the chain handle is missing or invalid, preventing calls into AppleCrypto with a null handle. - Ensure the copied certificate chain handle is disposed when it was created via
SslCopyCertChain(SafeDeleteSslContext path), even on the early-return path.
This was referenced Apr 27, 2026
Open
wfurt
reviewed
Apr 27, 2026
wfurt
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash in #123395