Skip to content

Re-enable OSX runtime-diagnostics legs#127492

Open
rcj1 wants to merge 5 commits intodotnet:mainfrom
rcj1:reenable-osx
Open

Re-enable OSX runtime-diagnostics legs#127492
rcj1 wants to merge 5 commits intodotnet:mainfrom
rcj1:reenable-osx

Conversation

@rcj1
Copy link
Copy Markdown
Contributor

@rcj1 rcj1 commented Apr 28, 2026

Fixes #126435

Copilot AI review requested due to automatic review settings April 28, 2026 04:24
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables macOS coverage for the runtime-diagnostics pipeline’s cDAC dump-test legs by adding osx_arm64 and osx_x64 back into the default cdacDumpPlatforms list.

Changes:

  • Add osx_arm64 and osx_x64 to the default cDAC dump-test platform matrix.

Comment thread eng/pipelines/runtime-diagnostics.yml
Copilot AI review requested due to automatic review settings April 28, 2026 19:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread src/native/managed/cdac/tests/DumpTests/cdac-dump-xplat-test-helix.proj Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 28, 2026 21:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@rcj1 rcj1 marked this pull request as ready for review April 29, 2026 17:45
Copilot AI review requested due to automatic review settings April 29, 2026 17:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cdac dump tests should disable system dump generation

3 participants