JIT: Use VisitLocalDefNodes from gtTreeHasLocalStore#127555
Draft
jakobbotsch wants to merge 5 commits intodotnet:mainfrom
Draft
JIT: Use VisitLocalDefNodes from gtTreeHasLocalStore#127555jakobbotsch wants to merge 5 commits intodotnet:mainfrom
VisitLocalDefNodes from gtTreeHasLocalStore#127555jakobbotsch wants to merge 5 commits intodotnet:mainfrom
Conversation
`gtTreeHasLocalStore` did not properly handle all definitions, skipping for example retbuf definitions. We have a low-level helper for this so use that.
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Compiler::gtTreeHasLocalStore to detect local definitions more robustly by delegating “what counts as a local def” to the existing GenTree::VisitLocalDefNodes helper (intended to cover cases beyond explicit GT_STORE_LCL_*, such as retbuf-related defs).
Changes:
- Replaced the direct
OperIsLocalStore()/AsLclVarCommon()logic with aVisitLocalDefNodes-based check. - Updated the early-exit path to use
GenTree::VisitResultfrom the helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gtTreeHasLocalStoredid not properly handle all definitions, skipping for example retbuf definitions. We have a low-level helper for this so use that.