JIT: Clean up and unify SELECT opts#127621
Open
BoyBaykiller wants to merge 3 commits intodotnet:mainfrom
Open
Conversation
* remove redundant select-to-cond opt in lower
github-actions
Bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
@jakobbotsch PTAL. 0 diffs 0 tp impact. Just making things a little nicer |
jakobbotsch
reviewed
May 1, 2026
| // | ||
| GenTree* OptIfConversionDsc::TryOptimizeSelect(GenTreeConditional* select) | ||
| { | ||
| if (GenTree* opt = TrySelectToCnsOpCond(select); opt != nullptr) |
Member
There was a problem hiding this comment.
We don't use this style of declaration in the JIT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My idea here is to make it easier to add SELECT transformations in the future and also call them from elsewhere in HIR if needed.
After this PR I want to add a few I think are impactful, but this PR should be zero-diff.
I also have the wish to get rid "optimizeBools" phase and implement it as just SELECT transformations (although this requires slight improvement in if-conversion itself)
I am also interested in moving the cost check after SELECT optimization, so costAfterOptSelect < costBranchful.
So that we transition to a view where if-conversions primary goal is to just simplify control flow and then let other opts profit from that.