Skip to content

Fix INT_MIN overflow in RangeCheck::BetweenBounds #127648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 2 commits into from
May 4, 2026
+9 −3
Merged

Fix INT_MIN overflow in RangeCheck::BetweenBounds #127648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5ba803
Fix INT_MIN overflow in RangeCheck::BetweenBounds
EgorBo May 1, 2026
fdad531
Update rangecheck.cpp
EgorBo May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/coreclr/jit/rangecheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,10 @@ bool RangeCheck::BetweenBounds(Range& range, GenTree* upper, int arrSize)
if (range.LowerLimit().IsBinOpArray())
{
int lcns = range.LowerLimit().GetConstant();
if (lcns >= 0 || -lcns > arrSize)
// Use "lcns < -arrSize" rather than "-lcns > arrSize" to avoid signed
// overflow when lcns == INT_MIN.
assert(arrSize > 0);
if (lcns >= 0 || lcns < -arrSize)
{
return false;
}
Expand Down Expand Up @@ -236,8 +239,11 @@ bool RangeCheck::BetweenBounds(Range& range, GenTree* upper, int arrSize)
if (range.LowerLimit().IsBinOpArray())
{
int lcns = range.LowerLimit().GetConstant();
// len + lcns, make sure we don't subtract too much from len.
if (lcns >= 0 || -lcns > arrSize)
// len + lcns, make sure we don't subtract too much from len. Use
// "lcns < -arrSize" rather than "-lcns > arrSize" to avoid signed
// overflow when lcns == INT_MIN.
assert(arrSize > 0);
if (lcns >= 0 || lcns < -arrSize)
{
return false;
}
Expand Down
Loading