[Wasm RyuJIT] Codegen for reverse pinvoke/unmanagedcallersonly#127751
Open
kg wants to merge 3 commits intodotnet:mainfrom
Open
[Wasm RyuJIT] Codegen for reverse pinvoke/unmanagedcallersonly#127751kg wants to merge 3 commits intodotnet:mainfrom
kg wants to merge 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WASM RyuJIT prolog to support methods where the WASM shadow stack pointer is not passed as an explicit argument (reverse P/Invoke / UnmanagedCallersOnly entrypoints), allowing the sample in the PR description to compile.
Changes:
- Introduces a WASM global index constant intended to represent the stack pointer global.
- Updates
CodeGen::genAllocLclFrameto initialize the SP local from a global when the SP “arg” is not actually a parameter (RPI case). - Keeps the existing SP-as-first-arg path for normal managed calling convention.
Member
Author
|
PTAL @dotnet/jit-contrib |
AndyAyersMS
reviewed
May 5, 2026
Member
AndyAyersMS
left a comment
There was a problem hiding this comment.
I think we may run into some trouble when lvaWasmSpArg does not represent an arg.
In particular compMapILargNum and compMap2ILvarNum are not prepared to handle this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sufficient to compile