Make Async Profiler tests compatible with single threaded runtime.#127762
Open
lateralusX wants to merge 6 commits intodotnet:mainfrom
Open
Make Async Profiler tests compatible with single threaded runtime.#127762lateralusX wants to merge 6 commits intodotnet:mainfrom
lateralusX wants to merge 6 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
lateralusX
force-pushed
the
lateralusX/async-profiler-test-adjustments
branch
from
b3a77ba to
fe86a97
Compare
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| if (wrapperName is null) | ||
| continue; | ||
| if (wrapperName.StartsWith(WrapperNamePrefix, StringComparison.Ordinal)) | ||
| return int.Parse(wrapperName.Substring(WrapperNamePrefix.Length)); |
| public IReadOnlyList<ParsedEvent> All => _events; | ||
|
|
||
| /// <summary>All distinct event IDs present in the stream.</summary> | ||
| public IEnumerable<AsyncEventID> EventIds => _events.Select(e => e.EventId); |
Comment on lines
+116
to
+120
| // [wrapperNameTemplateLength byte] | ||
| // [wrapperNameTemplate UTF8 bytes] | ||
| byte[] templateBytes = System.Text.Encoding.UTF8.GetBytes(ContinuationWrapper.NameTemplate); | ||
| const int MaxStaticEventPayloadSize = Serializer.MaxCompressedUInt64Size + Serializer.MaxCompressedUInt64Size + Serializer.MaxCompressedUInt64Size + Serializer.MaxCompressedUInt32Size + 1 + 1; | ||
| int maxDynamicEventPayloadSize = templateBytes.Length; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial async profiler tests used some techniques to isolate tests running on thread pool, but that doesn't work on single threaded platforms like WASM.
With these changes we now have all tests running on CoreCLR, NativeAOT and 38 out of 48 tests running on CoreCLR WASM single threaded configuration.