Skip to content

Remove RequiresUnsafeAnalyzer #127768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjonescz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove RequiresUnsafeAnalyzer #127768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
541 changes: 0 additions & 541 deletions src/tools/illink/src/ILLink.CodeFix/RequiresUnsafeCodeFixProvider.cs
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/tools/illink/src/ILLink.CodeFix/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,10 @@
<data name="RequiresDynamicCodeCodeFixTitle" xml:space="preserve">
<value>Add RequiresDynamicCode attribute to parent method</value>
</data>
<data name="RequiresUnsafeCodeFixTitle" xml:space="preserve">
<value>Add RequiresUnsafe attribute to parent method</value>
</data>
<data name="UconditionalSuppressMessageCodeFixTitle" xml:space="preserve">
<value>Add UnconditionalSuppressMessage attribute to parent method</value>
</data>
<data name="DynamicallyAccessedMembersCodeFixTitle" xml:space="preserve">
<value>Add DynamicallyAccessedMembers attribute to source of warning</value>
</data>
<data name="UnsafeMethodMissingRequiresUnsafeCodeFixTitle" xml:space="preserve">
<value>Add RequiresUnsafe attribute to method with pointer types</value>
</data>
</root>
83 changes: 0 additions & 83 deletions src/tools/illink/src/ILLink.CodeFix/UnsafeMethodMissingRequiresUnsafeCodeFixProvider.cs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/tools/illink/src/ILLink.RoslynAnalyzer/DynamicallyAccessedMembersAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ private static ImmutableArray<RequiresAnalyzerBase> GetRequiresAnalyzers()
builder.Add(new RequiresAssemblyFilesAnalyzer());
builder.Add(new RequiresUnreferencedCodeAnalyzer());
builder.Add(new RequiresDynamicCodeAnalyzer());
#if DEBUG
builder.Add(new RequiresUnsafeAnalyzer());
#endif
return builder.ToImmutable();
}

Expand Down
3 changes: 0 additions & 3 deletions src/tools/illink/src/ILLink.RoslynAnalyzer/MSBuildPropertyOptionNames.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ public static class MSBuildPropertyOptionNames
public const string IncludeAllContentForSelfExtract = nameof(IncludeAllContentForSelfExtract);
public const string EnableTrimAnalyzer = nameof(EnableTrimAnalyzer);
public const string EnableAotAnalyzer = nameof(EnableAotAnalyzer);
#if DEBUG
public const string EnableUnsafeAnalyzer = nameof(EnableUnsafeAnalyzer);
#endif
public const string VerifyReferenceAotCompatibility = nameof(VerifyReferenceAotCompatibility);
public const string VerifyReferenceTrimCompatibility = nameof(VerifyReferenceTrimCompatibility);
}
Expand Down
103 changes: 0 additions & 103 deletions src/tools/illink/src/ILLink.RoslynAnalyzer/RequiresUnsafeAnalyzer.cs
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions src/tools/illink/src/ILLink.RoslynAnalyzer/UnsafeMethodMissingRequiresUnsafeAnalyzer.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/tools/illink/src/ILLink.RoslynAnalyzer/build/Microsoft.NET.ILLink.Analyzers.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<CompilerVisibleProperty Include="EnableAotAnalyzer" />
<CompilerVisibleProperty Include="EnableSingleFileAnalyzer" />
<CompilerVisibleProperty Include="EnableTrimAnalyzer" />
<CompilerVisibleProperty Include="EnableUnsafeAnalyzer" />
<CompilerVisibleProperty Include="IncludeAllContentForSelfExtract" />
<CompilerVisibleProperty Include="VerifyReferenceTrimCompatibility" />
<CompilerVisibleProperty Include="VerifyReferenceAotCompatibility" />
Expand Down
13 changes: 0 additions & 13 deletions src/tools/illink/src/ILLink.Shared/DiagnosticId.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,16 +219,6 @@ public enum DiagnosticId
// Feature guard diagnostic ids.
ReturnValueDoesNotMatchFeatureGuards = 4000,
InvalidFeatureGuard = 4001,

#if DEBUG
// RequiresUnsafe diagnostics are in the 5000 range, separate from other diagnostics.
RequiresUnsafe = 5000,
RequiresUnsafeAttributeMismatch = 5001,
RequiresUnsafeOnStaticConstructor = 5002,
RequiresUnsafeOnEntryPoint = 5003,
UnsafeMethodMissingRequiresUnsafe = 5004,
_EndRequiresUnsafeWarningsSentinel,
#endif
}

public static class DiagnosticIdExtensions
Expand All @@ -253,9 +243,6 @@ public static string GetDiagnosticSubcategory(this DiagnosticId diagnosticId) =>
>= 2109 and < (int)DiagnosticId._EndTrimAnalysisWarningsSentinel => MessageSubCategory.TrimAnalysis,
>= 3050 and <= 3052 => MessageSubCategory.AotAnalysis,
>= 3054 and <= 3058 => MessageSubCategory.AotAnalysis,
#if DEBUG
>= 5000 and < (int)DiagnosticId._EndRequiresUnsafeWarningsSentinel => MessageSubCategory.None,
#endif
_ => MessageSubCategory.None,
};

Expand Down
30 changes: 0 additions & 30 deletions src/tools/illink/src/ILLink.Shared/SharedStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,34 +1269,4 @@
<data name="DataflowAnalysisDidNotConvergeMessage" xml:space="preserve">
<value>Trim dataflow analysis of member '{0}' took too long to complete. Trim safety cannot be guaranteed.</value>
</data>
<data name="RequiresUnsafeTitle" xml:space="preserve">
<value>Calling methods annotated with 'RequiresUnsafeAttribute' may break functionality in environments that do not support unsafe code.</value>
</data>
<data name="RequiresUnsafeMessage" xml:space="preserve">
<value>Using member '{0}' which has 'RequiresUnsafeAttribute' requires an unsafe context, such as an unsafe block or a method marked with 'RequiresUnsafeAttribute'.{1}{2}</value>
</data>
<data name="RequiresUnsafeAttributeMismatchTitle" xml:space="preserve">
<value>'RequiresUnsafeAttribute' annotations must match across all interface implementations or overrides.</value>
</data>
<data name="RequiresUnsafeAttributeMismatchMessage" xml:space="preserve">
<value>{0}. 'RequiresUnsafeAttribute' annotations must match across all interface implementations or overrides.</value>
</data>
<data name="RequiresUnsafeOnStaticConstructorMessage" xml:space="preserve">
<value>'RequiresUnsafeAttribute' cannot be placed directly on static constructor '{0}'.</value>
</data>
<data name="RequiresUnsafeOnStaticConstructorTitle" xml:space="preserve">
<value>'RequiresUnsafeAttribute' cannot be used on static constructors because they are not directly callable. Consider placing the attribute on the type instead.</value>
</data>
<data name="RequiresUnsafeOnEntryPointMessage" xml:space="preserve">
<value>'RequiresUnsafeAttribute' cannot be placed directly on application entry point '{0}'.</value>
</data>
<data name="RequiresUnsafeOnEntryPointTitle" xml:space="preserve">
<value>The use of 'RequiresUnsafeAttribute' on entry points is disallowed since the method will be called from outside the visible app.</value>
</data>
<data name="UnsafeMethodMissingRequiresUnsafeTitle" xml:space="preserve">
<value>Methods with pointer types in their signature should be annotated with 'RequiresUnsafeAttribute'.</value>
</data>
<data name="UnsafeMethodMissingRequiresUnsafeMessage" xml:space="preserve">
<value>Method '{0}' has pointer types in its signature but is not annotated with 'RequiresUnsafeAttribute'.</value>
</data>
</root>
Loading
Loading