Disable ThreadLocalContinuation_IsContinuation dump test on macOS#127777
Open
Disable ThreadLocalContinuation_IsContinuation dump test on macOS#127777
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a3d02837-a856-47a3-9d8a-773025e322f3 Co-authored-by: hoyosjs <19413848+hoyosjs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Disable ThreadLocalContinuation_IsContinuation test on macOS
Disable ThreadLocalContinuation_IsContinuation dump test on macOS
May 4, 2026
hoyosjs
approved these changes
May 4, 2026
rcj1
approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables a dump-based cDAC integration test (ThreadLocalContinuation_IsContinuation) for macOS dumps, because the required AsyncDispatcherInfo type is not present in CoreLib for those dumps and the test asserts before it can validate the intended behavior.
Changes:
- Add a
SkipOnOS("osx", ...)attribute to skipThreadLocalContinuation_IsContinuationwhen the dump metadata OS isosx.
jkotas
reviewed
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadLocalContinuation_IsContinuationfails on macOS Arm64 becauseAsyncDispatcherInfois not present in CoreLib in those dumps, causing an assertion failure before the test logic runs.Description
Adds
[SkipOnOS("osx", ...)]toThreadLocalContinuation_IsContinuationinAsyncContinuationDumpTests.cs, using the existingSkipOnOSAttributeconvention already in use across the DumpTests area. The skip is evaluated at test initialization time viaDumpTestBase.InitializeDumpTestagainst thedump-info.jsonOS field.