Add test for non-async generic methods mismatch in ILC scanner/JIT #127782
Open
eduardo-vp wants to merge 2 commits intodotnet:mainfrom
Open
Add test for non-async generic methods mismatch in ILC scanner/JIT #127782eduardo-vp wants to merge 2 commits intodotnet:mainfrom
eduardo-vp wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new async regression test intended to cover #127179 by exercising a generic async ValueTask<T> method awaiting a non-async generic method, targeting an ILC scanner vs JIT expectation mismatch scenario.
Changes:
- Introduces a new test project under
src/tests/async/awaitingnoasyncgeneric/usingMicrosoft.NET.Sdk.IL. - Adds a simple xUnit test that runs the pattern for both reference and value generic instantiations.
- Forces optimization on in the test project to ensure the relevant scanning/codegen path is exercised.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/async/awaitingnoasyncgeneric/awaitingnoasyncgeneric.csproj | New test project with optimization + process isolation settings. |
| src/tests/async/awaitingnoasyncgeneric/awaitingnoasyncgeneric.cs | New xUnit test and minimal repro pattern using generic ValueTask<T>. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced May 5, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding test for #127179.
ILC crashes when trying to compile a runtime async method on a generic type that calls a non-async generic method. The JIT tries to use the async call method whereas the scanner only generated information for the thunk.