[cDAC] implement DacDbi GetTypeLayout/GetArrayLayout#127877
Open
[cDAC] implement DacDbi GetTypeLayout/GetArrayLayout#127877
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/14d41630-8260-4774-af08-174c95098f28 Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
rcj1
changed the title
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This was referenced May 6, 2026
Open
jkotas
reviewed
May 7, 2026
| public virtual CorElementType GetSignatureCorElementType(TypeHandle typeHandle); | ||
|
|
||
| // Internal element type of the type. Unlike GetSignatureCorElementType, this returns the underlying | ||
| // primitive type for enums and PrimitiveValueType categories (e.g. I4 for an enum with int underlying type). |
Member
There was a problem hiding this comment.
The primitive value types is another historical artifact that we should delete #127894
| { | ||
| CorElementType elementType = GetSignatureCorElementType(typeHandle); | ||
| // Keep this aligned with CorTypeInfo::IsObjRef semantics for signature element types. | ||
| return elementType is CorElementType.String or CorElementType.Class or CorElementType.Array or CorElementType.Object or CorElementType.SzArray; |
Member
There was a problem hiding this comment.
Suggested change
| return elementType is CorElementType.String or CorElementType.Class or CorElementType.Array or CorElementType.Object or CorElementType.SzArray; | |
| return elementType is CorElementType.Class or CorElementType.Array or CorElementType.SzArray; |
Nit: This never returns CorElementType.Object or CorElementType.String
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements cDAC-side
DacDbitype/array layout APIs and adds RuntimeTypeSystem classification APIs required for this.