Fix static analysis findings in GC bridge and NativeAOT runtime#127893
Open
Fix static analysis findings in GC bridge and NativeAOT runtime#127893
Conversation
…nk handle cleanup Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f253b77c-d18d-4f6c-b8ed-9abbe61cfd38 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f253b77c-d18d-4f6c-b8ed-9abbe61cfd38 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
jkotas
reviewed
May 7, 2026
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
jkotas
approved these changes
May 7, 2026
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a17e077c-3c26-46f1-9178-bdd6980712d1 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
jkotas
reviewed
May 7, 2026
jkotas
reviewed
May 7, 2026
jkotas
reviewed
May 7, 2026
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/d3a0bfa0-0985-471c-9daf-95a6dfaaf158 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
…path Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/d3a0bfa0-0985-471c-9daf-95a6dfaaf158 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Member
|
@copilot Revert last two commits. They do not look like an improvement |
… comments) Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9fbcca80-de7f-4686-a0ea-6c342340a4f9 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Contributor
Author
Done in commit |
jkotas
reviewed
May 7, 2026
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/2f8f67fb-db2c-4a95-af22-5d55575174ef Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
jkotas
approved these changes
May 7, 2026
BrzVlad
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR description was generated with AI assistance.
Summary
src/coreclr/gc/gcbridge.cppby replacingfreewithdelete[]for memory allocated vianew[].CrstStaticwith inlineminipal_mutex, and asserting thatminipal_mutex_initsucceeds (bool success; success = minipal_mutex_init(&theLog.lock); _ASSERTE(success);).src/coreclr/nativeaot/Runtime/windows/PalMinWin.cppby guardingCloseHandlecalls forhMapandhFile.Validation
./build.sh clr+libs+host(pass)./build.sh clr+libs+host(pass)Notes
src/coreclr/inc/stresslog.handsrc/coreclr/utilcode/stresslog.cppwere reverted per reviewer feedback; those files remain unchanged from upstream.