Skip to content

Add note clarifying TLS use in HttpListener#128084

Merged
wfurt merged 3 commits into
dotnet:mainfrom
wfurt:HLDoc
May 13, 2026
Merged

Add note clarifying TLS use in HttpListener#128084
wfurt merged 3 commits into
dotnet:mainfrom
wfurt:HLDoc

Conversation

@wfurt
Copy link
Copy Markdown
Member

@wfurt wfurt commented May 12, 2026

doc only.

@wfurt wfurt requested review from a team and Copilot May 12, 2026 16:48
@wfurt wfurt added documentation Documentation bug or enhancement, does not impact product or test code area-System.Net labels May 12, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates HttpConnection with a comment intended to clarify why the managed HttpListener TLS code path is currently effectively unreachable and why CA5359 is suppressed in that block.

Changes:

  • Added explanatory comment in the secure constructor path around SslStream creation and CA5359 suppression.

Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 12, 2026 17:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Comment thread src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs Outdated
Copy link
Copy Markdown
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo existing comments

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 12, 2026 23:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@wfurt wfurt merged commit 52090b9 into dotnet:main May 13, 2026
91 of 93 checks passed
@wfurt wfurt deleted the HLDoc branch May 13, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Net documentation Documentation bug or enhancement, does not impact product or test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants