DRAFT: Createwhile write after read#128233
Draft
dhartglassMSFT wants to merge 5 commits into
Draft
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the SVE2 CreateWhileWriteAfterReadMask* (WHILEWR) intrinsic family alongside the existing CreateWhileReadAfterWriteMask* (WHILERW) family, and extends the shared test template to cover both, including a new "reverse offset by one" scenario that exercises the asymmetric behavior between the two instructions.
Changes:
- Adds 10 new
CreateWhileWriteAfterReadMask{Type}public APIs (Sve2) in ref assembly, the throwing PlatformNotSupported stubs, and the recursive forwarding stubs inSve2.cs. - Wires up the new intrinsics in
hwintrinsiclistarm64sve.h(mapping each base type toINS_sve_whilewr) and extends theEA_8BYTEpointer-operand codegen case inhwintrinsiccodegenarm64.cppto cover the new IDs. - Renames the shared SVE RW test template to
SveCreateWhileDependencyMaskTest, parameterizes it withIsWriteAfterRead, adds aRunReverseOffsetByOneScenariodistinguishing WHILEWR vs WHILERW, and adds 10 generator entries for the new WHILEWR tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs | Adds 10 new ref APIs for CreateWhileWriteAfterReadMask*. |
| src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.PlatformNotSupported.cs | Adds throwing stubs and XML docs for the new intrinsics. |
| src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.cs | Adds the runtime intrinsic forwarding entry points. |
| src/coreclr/jit/hwintrinsiclistarm64sve.h | Registers the 10 new intrinsic IDs mapped to INS_sve_whilewr per base type. |
| src/coreclr/jit/hwintrinsiccodegenarm64.cpp | Routes the new IDs through the existing 64-bit pointer codegen path (comment updated to WHILERW/WHILEWR). |
| src/tests/Common/GenerateHWIntrinsicTests/Arm/Templates.cs | Renames the template config to SveCreateWhileDependencyMaskTest. |
| src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs | Updates RW entries with IsWriteAfterRead=false and adds 10 WHILEWR entries with IsWriteAfterRead=true. |
| src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveCreateWhileDependencyMaskTest.template | Renames the test class, adds RunReverseOffsetByOneScenario, and documents the WHILEWR/WHILERW spec semantics. |
This was referenced May 15, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.