Update EmsdkPackageVersion to use version from dependency flow#128261
Update EmsdkPackageVersion to use version from dependency flow#128261akoeplinger wants to merge 2 commits into
Conversation
It got hardcoded a while ago to workaround a build problem.
There was a problem hiding this comment.
Pull request overview
This PR updates the build’s Emscripten SDK provisioning versioning so it no longer relies on a hardcoded EmsdkPackageVersion value in eng/Versions.props, instead sourcing it from a dependency-flow-updated property.
Changes:
- Replace the hardcoded
EmsdkPackageVersion(10.0.0) with$(MicrosoftDotNetApiCompatTaskPackageVersion). - Add an explanatory comment about why a stable, dependency-flow-backed version property is used.
|
Caution Security scanning requires review for Code Review DetailsThe threat detection results could not be parsed. The workflow output should be reviewed before merging. Review the workflow run logs for details. Code Review: Update EmsdkPackageVersion to use version from dependency flowVerdict: APPROVED ✅ SummaryThis is a minimal, well-scoped fix. Analysis
No issues found. The change is correct and improves maintainability by removing a hardcoded version that would need manual bumps.
|
It got hardcoded a while ago to workaround a build problem.