Skip to content

Prioritize setTgtPref for the op1 use #128333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tannergooding wants to merge 2 commits into from
+0 −7
Closed

Prioritize setTgtPref for the op1 use #128333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8e7010
Only track a single target preference
tannergooding May 18, 2026
f6c251e
Check allowing tgtPrefUse2 for BuildSelect
tannergooding May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/coreclr/jit/lsraxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,13 +967,6 @@ int LinearScan::BuildSelect(GenTreeOp* select)
srcCount++;
Comment thread
tannergooding marked this conversation as resolved.
}

if ((tgtPrefUse != nullptr) && (tgtPrefUse2 != nullptr))
{
// CQ analysis shows that it's best to always prefer only the 'true'
// val here.
tgtPrefUse2 = nullptr;
}

// Codegen will emit something like:
//
// mov dstReg, falseVal
Expand Down
Loading