Remove Attributes.BoxedValues from ILTrim expected failures#128337
Merged
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9fc8c55e-3019-41d3-a060-7174d0b83b25 Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failure for Attributes.BoxedValues
Remove Attributes.BoxedValues from ILTrim expected failures
May 18, 2026
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
jkotas
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a now-passing ILTrim test case from the expected-failures list so the ILTrim test harness no longer fails because Attributes.BoxedValues is listed as an expected failure while passing.
Changes:
- Removed
Attributes.BoxedValuesfromILTrimExpectedFailures.txt.
Member
|
/ba-g Tools-tests was green before the CI reset and we don't care about the rest. Merging to fix main. |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Mono.Linker.Tests.TestCases.All.AttributesTests(testCase: Attributes.BoxedValues)test was failing with:The test started passing (likely as a side effect of #127596), and the harness fails any entry in
ILTrimExpectedFailures.txtthat no longer reproduces.Changes
Attributes.BoxedValuesfromsrc/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt.