Skip to content

Reject negative PAX size values when reading TAR headers #128368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iremyux wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

Reject negative PAX size values when reading TAR headers #128368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c7bf7
Validate size
iremyux May 19, 2026
51365a9
Remove spaces
iremyux May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Read.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,11 @@ internal void ReplaceNormalAttributesWithExtended(IEnumerable<KeyValuePair<strin
// The 'size' header field only fits 12 bytes, so the data section length that surpases that limit needs to be retrieved
if (TarHelpers.TryGetStringAsBaseTenLong(ExtendedAttributes, PaxEaSize, out long size))
{
if (size < 0)
Copy link
Copy Markdown
Member

@MihaZupan MihaZupan May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something worth having a test for?

{
throw new InvalidDataException(SR.Format(SR.TarSizeFieldNegative));
Comment thread
iremyux marked this conversation as resolved.
}

Comment thread
iremyux marked this conversation as resolved.
_size = size;
}

Expand Down
Loading