Fix for index out of bounds in sve scatter test#128419
Merged
Merged
Conversation
dhartglassMSFT
requested review from
SwapnilGaikwad and
Copilot
and removed request for
Copilot
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
Author
|
Hey @SwapnilGaikwad added you on this one, history says you edited these a while ago |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SVE scatter test template setup logic to prevent generated scatter index values from exceeding the output buffer length, addressing a sporadic “Index … exceeds array length 1024” assertion during test construction.
Changes:
- Fix
MakeDistinctto keep indices within[0, OutElementCount)by wrapping with modulo when resolving duplicates. - Adjust the duplicate-handling step from
+= sizeof(...)(which can push indices out of range) to+ 1with clamping. - Minor comment grammar fix (“exists”).
adamperlin
approved these changes
May 22, 2026
Contributor
adamperlin
left a comment
adamperlin
left a comment
There was a problem hiding this comment.
LGTM, especially if this behavior exists already in a similar test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
Sve_Scatter8BitNarrowing_long_ulonggets "Index 1031 exceeds array length 1024" on osx arm64. This assert comes out of test setupI could not reproduce this locally - a couple of these ScatterNBitNarrowing tests failed sporadically across different pipelines, but locally I couldn't get the RNG to line up.
The error itself is printed when the test input array contains out of bounds data. Likely a problem with test setup -
SveScatterVector.template(see MakeDistinct) already clamps its index values to array length, so the same fix is needed inSveScatterVectorBases.templatefixes #128311