Skip to content

Add ILLink analyzer primary constructor repro#128467

Closed
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-analyzer-debug-assertion
Closed

Add ILLink analyzer primary constructor repro#128467
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-analyzer-debug-assertion

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

Enabling the trim/AOT analyzers for System.Runtime.Tests currently exposes a debug assertion in ILLink analyzer dataflow when Roslyn reports a primary-constructor operation block with the containing type as the owning symbol.

This scopes the change to a CI-visible repro only:

  • Adds a primary-constructor type to AnnotatedMembersAccessedViaReflection
  • Leaves analyzer behavior unchanged so CI can capture the failure

Copilot AI and others added 4 commits May 18, 2026 09:06
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0a2f12ac-4c67-4296-8c19-f96183fc6dc4

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0a2f12ac-4c67-4296-8c19-f96183fc6dc4

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0a2f12ac-4c67-4296-8c19-f96183fc6dc4

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/182a0f53-6614-4321-b6d7-397ad71530ae

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 22, 2026 01:33
@dotnet-policy-service dotnet-policy-service Bot added the linkable-framework Issues associated with delivering a linker friendly framework label May 22, 2026
@github-actions github-actions Bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label May 22, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/illink
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Copy Markdown
Member

No repro. Looking through the logs, the AI had trouble building the project in the first place, then it gave up and started guessing based on code review. It's likely something else that is tripping the assert. I'll need to repro myself one of these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants