JIT: Canonicalize '(A & pow2) == pow2' -> '(A & pow2) != 0'#128533
Open
BoyBaykiller wants to merge 3 commits into
Open
JIT: Canonicalize '(A & pow2) == pow2' -> '(A & pow2) != 0'#128533BoyBaykiller wants to merge 3 commits into
BoyBaykiller wants to merge 3 commits into
Conversation
* '(A & pow2) != pow2' -> '(A & pow2) == 0'
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Open
3 tasks
Contributor
|
@MihuBot -nuget |
| // '(A & pow2) == pow2' -> '(A & pow2) != 0' | ||
| // '(A & pow2) != pow2' -> '(A & pow2) == 0' | ||
| if (cmp->OperIs(GT_EQ, GT_NE) && cmp->gtGetOp1()->OperIs(GT_AND) && | ||
| cmp->gtGetOp1()->gtGetOp2()->IsIntegralConst() && cmp->gtGetOp2()->IsIntegralConstUnsignedPow2()) |
Contributor
There was a problem hiding this comment.
Does this correctly bail out when pow2 is 0?
Contributor
Author
There was a problem hiding this comment.
yes,
runtime/src/coreclr/jit/utils.h
Lines 65 to 68 in 17cd11c
…it-test-to-zero-on-right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically so we always have 0 at the right-side:
Tthis currently helps optimizeBools, but I am also adding this with the future in mind.
Here is one example:
Note: With #126852 this would then get transformed into just
test 12.