JIT: Defer fgSetOptions until after 2nd-pass EH removal#128573
Merged
AndyAyersMS merged 1 commit intoMay 26, 2026
Conversation
The JIT will sometimes commit to fully-interruptible GC too early. Wait until we've had a second chance to remove EH regions.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the JIT compilation pipeline ordering so fgSetOptions() (which commits to codegen choices like fully-interruptible GC and frame-pointer requirements) runs later, after additional post-morph EH cleanup has had a chance to remove empty EH regions.
Changes:
- Removed the early
fgSetOptions()call from the post-morph phase. - Added
fgSetOptions()after the second-pass empty-EH removal / post-morph flow work, just before MD array morphing.
EgorBo
approved these changes
May 26, 2026
jakobbotsch
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JIT will sometimes commit to fully-interruptible GC too early. Wait until we've had a second chance to remove EH regions.