[release/10.0] Fix Linux madvise() advice values#128605
Merged
JulieLeeMSFT merged 1 commit intoMay 27, 2026
Merged
Conversation
… via bitwise OR Backport of dotnet#126966 to release/10.0
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/gc |
jkotas
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This backport fixes GCToOSInterface::VirtualReset on Unix by ensuring Linux madvise() receives a single advice constant per call (rather than an invalid bitwise-OR combination), restoring correct page-reclaim behavior and avoiding unintended advice interpretation on newer kernels.
Changes:
- Split the combined
madvise()call into two independent calls: one forMADV_DONTDUMP(coredump hint) and one forMADV_FREE(page-reclaim hint). - Use
#ifdef MADV_FREEas the compile-time guard (instead ofHAVE_MADV_FREE) and makeposix_madvise(POSIX_MADV_DONTNEED)a proper fallback only whenMADV_FREEisn’t available.
JulieLeeMSFT
approved these changes
May 26, 2026
Member
JulieLeeMSFT
left a comment
There was a problem hiding this comment.
LGTM.
cc @a74nh, @SwapnilGaikwad, @dhartglassMSFT, @EgorBo.
This was referenced May 27, 2026
Open
Member
|
/ba-g known issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #126966 to release/10.0
Customer Impact
VirtualResetin GC was combiningMADV_FREE(8) andMADV_DONTDUMP(16) via bitwise OR and passing the result (24) to a singlemadvisecall.madvisetakes a single advice constant — not a bitmask — so this was either rejected asEINVAL(kernels < 5.18) or silently matchedMADV_DONTNEED_LOCKED(kernels ≥ 5.18), a completely different operation.Regression
Testing
CI tests, local testing using targeted repro app from the customer, GC tests
Risk
Low. It is a simple targeted fix that just makes two calls to
madvisewith correct arguments where we were making one call with a combination of those values that had no effect or was outright wrong.