Skip to content

Extend timeout of libs legs in nativeaot-outerloop#128622

Merged
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-2
May 27, 2026
Merged

Extend timeout of libs legs in nativeaot-outerloop#128622
MichalStrehovsky merged 1 commit into
mainfrom
MichalStrehovsky-patch-2

Conversation

@MichalStrehovsky
Copy link
Copy Markdown
Member

Product & test build takes around 3 hours. If Helix is backed up enough, it can take 2+ hours to process these workitems. Clicking through the past few outerloop runs, this is the number 1 reason when they're red.

Product & test build takes around 3 hours. If Helix is backed up enough, it can take 2+ hours to process these workitems. Clicking through the past few outerloop runs, this is the number 1 reason when they're red.
Copilot AI review requested due to automatic review settings May 27, 2026 05:14
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

@github-actions
Copy link
Copy Markdown
Contributor

Code Review: Extend timeout of libs legs in nativeaot-outerloop

Summary

This PR increases timeoutInMinutes from 300 (5 hours) to 360 (6 hours) for three NativeAOT library test legs in the outerloop pipeline:

  • NativeAOT_Libs
  • NativeAOT_Checked_Libs_SizeOpt
  • NativeAOT_Checked_Libs_SpeedOpt

Analysis

Category Assessment
Correctness ✅ No issues — the change is a straightforward numeric constant bump applied consistently to all three affected jobs.
Consistency ✅ All three lib legs are updated to the same value.
Risk ✅ Extremely low — only affects CI timeout thresholds, no product code changes.

The existing comment ("doesn't normally take this long, but I've seen Helix queues backed up for 160 minutes") remains accurate — the extra hour of headroom is a reasonable buffer given the described 3-hour build + 2+ hour Helix queue scenario.

Verdict

APPROVED — no issues found. The change is minimal, well-motivated, and correctly applied to all relevant jobs.

Generated by Code Review for issue #128622 · ● 530K ·

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@MichalStrehovsky MichalStrehovsky merged commit 843084e into main May 27, 2026
117 of 125 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch May 27, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants