Extend timeout of libs legs in nativeaot-outerloop#128622
Merged
Merged
Conversation
Product & test build takes around 3 hours. If Helix is backed up enough, it can take 2+ hours to process these workitems. Clicking through the past few outerloop runs, this is the number 1 reason when they're red.
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
Code Review: Extend timeout of libs legs in nativeaot-outerloopSummaryThis PR increases
Analysis
The existing comment ("doesn't normally take this long, but I've seen Helix queues backed up for 160 minutes") remains accurate — the extra hour of headroom is a reasonable buffer given the described 3-hour build + 2+ hour Helix queue scenario. VerdictAPPROVED — no issues found. The change is minimal, well-motivated, and correctly applied to all relevant jobs.
|
jkotas
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product & test build takes around 3 hours. If Helix is backed up enough, it can take 2+ hours to process these workitems. Clicking through the past few outerloop runs, this is the number 1 reason when they're red.